fix(binary-codec): align confidential MPT wire fields - #346
Draft
kpitapeersyst wants to merge 3 commits into
Draft
fix(binary-codec): align confidential MPT wire fields#346kpitapeersyst wants to merge 3 commits into
kpitapeersyst wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(binary-codec): align confidential MPT wire fields
Description
This PR aligns confidential MPT field definitions and serialization with the canonical XRPL wire format. It corrects commitment and blinding-factor metadata while preserving hexadecimal
UInt64behavior for ordinary fields and using base-ten encoding only where explicitly declared by the field definitions.Type of change
Checklist:
Changes
BlindingFactoras a non-variable-lengthHash256field with the canonical ordinal.AmountCommitmentandBalanceCommitment.UInt64fields as base-ten in the field definitions.UInt64conversion only when the field metadata requires it.UInt64fields.Tests
CGO_ENABLED=1 CC=gcc go test ./binary-codec/... ./pkg/typecheckCI status
Note
The current
Lint and TestandRun govulncheckfailures are expected until #345 is merged intoconfidential-transfers. The target branch already contains the updatedmpt-cryptoheader, but it does not yet contain the matching CGo decryption call added by #345. This PR does not modifyconfidential/mptcrypto.After #345 is merged, this branch will be rebased onto the updated target branch and the checks will run again.
Notes
confidential-transfersintegration branch.